Skip to content

[WIP] Use sequence instead of raw strings#6

Closed
fridex wants to merge 1 commit into
thoth-station:masterfrom
fridex:quote-as-token
Closed

[WIP] Use sequence instead of raw strings#6
fridex wants to merge 1 commit into
thoth-station:masterfrom
fridex:quote-as-token

Conversation

@fridex
Copy link
Copy Markdown
Contributor

@fridex fridex commented Apr 16, 2018

No description provided.

@fridex
Copy link
Copy Markdown
Contributor Author

fridex commented Apr 16, 2018

@fridex fridex changed the title Use sequence instead of raw strings WIP: Use sequence instead of raw strings Apr 16, 2018
@goern
Copy link
Copy Markdown
Member

goern commented Nov 29, 2018

@fridex is this still relevant? we are waiting on upstream fixes?

1 similar comment
@goern
Copy link
Copy Markdown
Member

goern commented Feb 15, 2019

@fridex is this still relevant? we are waiting on upstream fixes?

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2019
@fridex
Copy link
Copy Markdown
Contributor Author

fridex commented Feb 15, 2019

@fridex is this still relevant? we are waiting on upstream fixes?

yes, I will have a look at it, there are some review comments to target.

@fridex
Copy link
Copy Markdown
Contributor Author

fridex commented Feb 15, 2019

If upstream is not willing to fix the current behavior, we can still do shlex.quote() and pass quoted strings instead.

@goern goern changed the title WIP: Use sequence instead of raw strings [WIP] Use sequence instead of raw strings Oct 6, 2019
@goern goern changed the title [WIP] Use sequence instead of raw strings [WIP] Use sequence instead of raw strings Oct 8, 2019
@goern goern changed the title [WIP] Use sequence instead of raw strings [WIP] Use sequence instead of raw strings Oct 8, 2019
@sefkhet-abwy sefkhet-abwy Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2019
@goern
Copy link
Copy Markdown
Member

goern commented Oct 23, 2019

recheck

@ghost
Copy link
Copy Markdown

ghost commented Oct 23, 2019

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@goern
Copy link
Copy Markdown
Member

goern commented Mar 23, 2020

is this still valid?

@fridex fridex closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. work-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants